Skip to content

feat(btrfs): add compression scheme selection for subvolumes - #4673

Closed
Erox-02 wants to merge 1 commit into
archlinux:masterfrom
Erox-02:master
Closed

feat(btrfs): add compression scheme selection for subvolumes#4673
Erox-02 wants to merge 1 commit into
archlinux:masterfrom
Erox-02:master

Conversation

@Erox-02

@Erox-02 Erox-02 commented Jul 26, 2026

Copy link
Copy Markdown

Add ability to choose compression scheme for BTRFS subvolumes

What this PR does

Adds user-selectable compression for BTRFS subvolumes during installation.

  • Adds BtrfsCompression enum with lzo and zstd:1-19 options
  • Adds compression selection menu to subvolume creation UI
  • Compression saved per-subvolume and applied during creation
  • JSON config supports compression field

Currently users can't choose compression algorithm (hardcoded to zstd:3).
Different use cases need different balances of speed vs compression.

Testing

  • Interactive installation with compression selection
  • JSON config with compression values
  • Verified mount options and chattr +c applied
  • Backward compatibility tested

#2681 fixed
issue closed

@Erox-02
Erox-02 requested a review from Torxed as a code owner July 26, 2026 15:56
@Erox-02

Erox-02 commented Jul 26, 2026

Copy link
Copy Markdown
Author
archinstall

@svartkanin

svartkanin commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

You changed the formatting of the edited files can you please revert that

@Erox-02

Erox-02 commented Jul 27, 2026

Copy link
Copy Markdown
Author

Ok i shall patch it by tomorrow

@Erox-02

Erox-02 commented Jul 27, 2026

Copy link
Copy Markdown
Author

@svartkanin PR ready for review. All merge conflicts resolved - kept master's formatting/arch changes and my BtrfsCompression changes. Tested and working. Thanks!

@svartkanin

svartkanin commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Please remove the AI comments. I'll not spent time reviewing code that you have not reviewed yourself.

@Erox-02

Erox-02 commented Jul 28, 2026

Copy link
Copy Markdown
Author

@svartkanin I've rechecked my code , updated to newest merge and removed the comments , ready for review

svartkanin
svartkanin reviewed Jul 31, 2026
View reviewed changes
Comment thread archinstall/lib/disk/device_handler.py Outdated
info(f'Creating subvolumes: {path}')

mount(path, self._TMP_BTRFS_MOUNT, create_target_mountpoint=True)
# MODIFIED: Build mount options including compression from subvolumes

@svartkanin svartkanin Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this here?

svartkanin
svartkanin reviewed Jul 31, 2026
View reviewed changes
Comment thread archinstall/lib/disk/device_handler.py Outdated

umount(path)

# ============================================================

@svartkanin svartkanin Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this here?

svartkanin
svartkanin reviewed Jul 31, 2026
View reviewed changes
Comment thread archinstall/lib/disk/subvolume_menu.py Outdated
data = [d for d in data if d != entry]

return data
def __init__(

@svartkanin svartkanin Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is modified

@Erox-02

Erox-02 commented Jul 31, 2026

Copy link
Copy Markdown
Author

@svartkanin Clean PR ready. Only 4 files changed. Removed AI comments, fixed indentation. Ready for review.

@svartkanin

svartkanin commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Given that this still has the same formatting issues I strongly believe there's only LLM being used without any review of your own code

@svartkanin svartkanin closed this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svartkanin svartkanin svartkanin left review comments
@Torxed Torxed Awaiting requested review from Torxed Torxed is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Erox-02 @svartkanin